[ADD] estate,estate_account: technical onboarding commit by jupir-odoo · Pull Request #1285 · odoo/tutorials

jupir-odoo · 2026-05-19T15:06:30Z

[ADD] estate,estate_accountant: technical onboarding commit

Problem:
There is currently no modules to manage real estate businesses in odoo.

Solution:
Implement estate properties, offer, tags, and types models with the associated views.

task-6229399

robodoo · 2026-05-19T15:06:34Z

jupir-odoo · 2026-05-21T13:49:31Z

@aboo-odoo kind reminder :D

aboo-odoo

Phenomenal work 🥳 I'm being extra-picky so that I can transmit as much information as possible. If there is anything you disagree with, please share it without fear.

Some comments apply at several places but I've only written it once to save some time and to not cumbersome the PR, when you check and update according to one of my comment, check that this comment does not apply elsewhere before moving to the next one 😄

A generic comment:

your PR/commit body could be a little more exhaustive a good template is to follow is

STEPS to reproduce the bug (only for bugfixes)
PROBLEM - what is the problem 
GOAL - what do we want to achieve
SOLUTION - how did we achieve it 

task-XXXXXX

aboo-odoo · 2026-05-22T09:37:57Z

In a Model attribute order should be:

Private attributes (_name, _description, _inherit, …)

Default method and default_get

Field declarations

SQL constraints and indexes

Compute, inverse and search methods in the same order as field declaration

Selection method (methods used to return computed values for selection fields)

Constrains methods (@api.constrains) and onchange methods (@api.onchange)

CRUD methods (ORM overrides)

Action methods

And finally, other business methods.

aboo-odoo · 2026-05-22T09:38:29Z

+        copy=False, default=datetime.today() + relativedelta(months=3)
+    )
+    expected_price = fields.Float(required=True)
+    _expected_price_constraint = models.Constraint(


The two constraints should be just after the _order attribute 😄

aboo-odoo · 2026-05-22T09:39:30Z

+
+
+class EstatePropery(models.Model):
+    _name = "estate.property"


There is a tacit convention that strings viewed by the users are surrounded by ", otherwise it is '

Suggested change

_name = "estate.property"

_name = 'estate.property'

aboo-odoo · 2026-05-22T09:40:52Z

+    garden_area = fields.Integer()
+    garden_orientation = fields.Selection(
+        string="Orientation",
+        selection=[("N", "North"), ("E", "East"), ("S", "South"), ("W", "West")],


Consider selection and a kind of dictionary, for dictionaries, you would write the keys in lower letters

Suggested change

selection=[("N", "North"), ("E", "East"), ("S", "South"), ("W", "West")],

selection=[('north', "North"), ('east', "East"), ('south', "South"), ('west', "West")],

Also, don't hesitate to be exhaustive in your name; estate.garden_orientation = 'north' is a bit clearer than estate.garden_orientation = 'n'

aboo-odoo · 2026-05-22T09:45:17Z

+        default="new",
+    )
+
+    def action_cancel_property(self):


self is a recordset, i.e. a collection of records. Your method would failed if called on several records when trying to perform self.state.

Currently, through the UI, you cannot trigger the error, but from the command line or a server action, users could get the traceback.

side note: you can run odoo in terminal mode by adding shell after odoo-bin: python odoo-bin shell --addons-path .... From there, you could perform

estates = self.env['estate.property'].create([{'name': 'TEST1', ADD the other relevant key-value pairs}, {'name': 'TEST2', ADD the other relevant key-value pairs}]) estates.action_cancel_property() # This should trigger the traceback

There are two ways to solve the issue:

begin your method with self.ensure_one(), quite self explanatory

or use a for loop like in _compute methods

aboo-odoo · 2026-05-22T10:04:53Z

+    )
+
+    def action_accept(self):
+        if self.property_id.state == "sold":


What happens if the property is cancelled ?

aboo-odoo · 2026-05-22T10:07:18Z

+    @api.model
+    def create(self, vals):


It would be preferable that you create the records in a batch rather than one by one, better performances 😄

Suggested change

@api.model

def create(self, vals):

@api.model_create_multi

def create(self, vals_list):

aboo-odoo · 2026-05-22T10:08:57Z

+            if float_compare(property.best_price, record["price"], 2) == 1:
+                raise UserError("You already have a higher offer")
+
+            if hasattr(property, "state"):


The property model always has the state attribute (you defined it as field), in what scenario could you not have one ?

aboo-odoo · 2026-05-22T10:12:54Z

+    ],
+    "installable": True,
+    "application": True,
+    "author": "Julien (jupir)",


Everything you create for Odoo belongs to "Odoo S.A." hehe

Suggested change

"author": "Julien (jupir)",

"author": "Odoo S.A.",

aboo-odoo · 2026-05-22T10:16:44Z

+            delta = timedelta(days=offer.validity)
+            offer.date_deadline = (
+                offer.create_date.date() + delta
+                if offer.create_date
+                else today() + delta
+            )


Alternatively (one-liner)

Suggested change

delta = timedelta(days=offer.validity)

offer.date_deadline = (

offer.create_date.date() + delta

if offer.create_date

else today() + delta

)

offer.date_deadline = (offer.create_date or today()).date() + timedelta(days=offer.validity)

aboo-odoo · 2026-05-26T09:43:03Z

+    description = fields.Text()
+    postcode = fields.Char()
+    date_availability = fields.Date(
+        copy=False, default=datetime.today() + relativedelta(months=3)


I've just noticed an issue here:

when declaring the default value like so, it will get computed once you start the database. The computed value will then be used until your database is restarted. This means that if you start your db today 26/05 and let it run for a month and that, on the 26/06 you create a new property record, the default date_availibility will be 26/08 (mai + 3 month) while we expect it to be 26/09 (june + 3 month).

To make the default value recomputed at each call; you need to call a function

Problem: There is currently no modules to manage real estate businesses in odoo. Solution: Implement estate properties, offer, tags, and types models with the associated views. task-6229399

jupir-odoo · 2026-05-27T09:47:27Z

Hello @aboo-odoo, j'ai appliqué tes conseils. Merci beaucoup. J'ai aussi fait le tuto sur les unit tests. Je ne sais pas si tu préfères que je les push aussi ici ou que je crée une deuxième PR. Merci d'avance !

aboo-odoo self-requested a review May 21, 2026 07:48

jupir-odoo force-pushed the 19.0-tuto-server-jupir branch from 07fb131 to 2b8c4ec Compare May 21, 2026 13:47

jupir-odoo changed the title ~~19.0 tuto server jupir~~ [ADD] estate,estate_accountant: technical onboarding commit May 21, 2026

jupir-odoo force-pushed the 19.0-tuto-server-jupir branch from 2b8c4ec to 5c36dbc Compare May 21, 2026 14:19

jupir-odoo changed the title ~~[ADD] estate,estate_accountant: technical onboarding commit~~ [ADD] estate,estate_account: technical onboarding commit May 21, 2026

aboo-odoo reviewed May 22, 2026

View reviewed changes

jupir-odoo force-pushed the 19.0-tuto-server-jupir branch from 5c36dbc to 4fd2d3b Compare May 22, 2026 11:30

aboo-odoo reviewed May 26, 2026

View reviewed changes

jupir-odoo force-pushed the 19.0-tuto-server-jupir branch from 4fd2d3b to 9001c34 Compare May 26, 2026 15:11

[ADD] estate,estate_accountant: technical onboarding commit

985deb6

Problem: There is currently no modules to manage real estate businesses in odoo. Solution: Implement estate properties, offer, tags, and types models with the associated views. task-6229399

jupir-odoo force-pushed the 19.0-tuto-server-jupir branch from 9001c34 to 985deb6 Compare May 27, 2026 07:31

jupir-odoo self-assigned this May 27, 2026

	selection=[("N", "North"), ("E", "East"), ("S", "South"), ("W", "West")],
	selection=[('north', "North"), ('east', "East"), ('south', "South"), ('west', "West")],

Conversation

jupir-odoo commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented May 19, 2026

Uh oh!

jupir-odoo commented May 21, 2026

Uh oh!

aboo-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jupir-odoo commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jupir-odoo commented May 19, 2026 •

edited

Loading

aboo-odoo left a comment •

edited

Loading